From b9aa5bae632ece076ff82e76a669fb0fb9143107 Mon Sep 17 00:00:00 2001 From: rxdn <29165304+rxdn@users.noreply.github.com> Date: Wed, 2 Jun 2021 16:37:08 +0100 Subject: [PATCH] Compare userid first --- app/http/endpoints/manage/logsview.go | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/app/http/endpoints/manage/logsview.go b/app/http/endpoints/manage/logsview.go index b5b54fb..98c5839 100644 --- a/app/http/endpoints/manage/logsview.go +++ b/app/http/endpoints/manage/logsview.go @@ -59,15 +59,17 @@ func LogViewHandler(ctx *gin.Context) { } // Verify the user has permissions to be here - permLevel, err := utils.GetPermissionLevel(guildId, userId) - if err != nil { - ctx.JSON(500, utils.ErrorJson(err)) - return - } + if ticket.UserId != userId { + permLevel, err := utils.GetPermissionLevel(guildId, userId) + if err != nil { + ctx.JSON(500, utils.ErrorJson(err)) + return + } - if permLevel < permission.Support && ticket.UserId != userId { - ctx.Redirect(302, config.Conf.Server.BaseUrl) // TODO: 403 Page - return + if permLevel < permission.Support { + ctx.Redirect(302, config.Conf.Server.BaseUrl) // TODO: 403 Page + return + } } // retrieve ticket messages from bucket